Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Fix route query params for offers/:offer_id. #2927

Merged
merged 1 commit into from
Aug 19, 2020
Merged

services/horizon: Fix route query params for offers/:offer_id. #2927

merged 1 commit into from
Aug 19, 2020

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Aug 18, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fix route query params for offers/:offer_id.

Why

The route was defining the ID query param as :id but the action handler was trying to find :offer_id -- making all request of type /offers/XX to return 404.

This bug was introduced in horizon-v1.7.0

Known limitations

@cla-bot cla-bot bot added the cla: yes label Aug 18, 2020
@abuiles abuiles requested a review from a team August 18, 2020 22:49
@abuiles abuiles added the bug label Aug 18, 2020
@2opremio
Copy link
Contributor

@abuiles would you mind basing the change on tag horizon-v1.7.0 and merging into a new branch release-horizon-v1.7.1 ?

I will merge to master afterwards.

@abuiles abuiles force-pushed the fix-get-offer-by-id branch from 4816509 to dad9253 Compare August 19, 2020 01:38
@abuiles abuiles changed the base branch from master to release-horizon-v1.7.1 August 19, 2020 01:39
@abuiles
Copy link
Contributor Author

abuiles commented Aug 19, 2020

@2opremio done -I created a release branch which is branched off from 1.7 and this PR is going there.

@abuiles abuiles merged commit 85a9270 into stellar:release-horizon-v1.7.1 Aug 19, 2020
@abuiles abuiles deleted the fix-get-offer-by-id branch August 19, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2opremio 2opremio 2opremio approved these changes

@ire-and-curses ire-and-curses ire-and-curses approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abuiles @2opremio @ire-and-curses